cursorPosition() to fit coding style
ClosedPublic
Actions

Authored by loh.tar on Dec 6 2018, 3:02 PM.

Details

Reviewers

cullmann
dhaumann

Group Reviewers

KTextEditor

Commits

Repository

R39 KTextEditor

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

loh.tar requested review of this revision.Dec 6 2018, 3:02 PM

Without any special "Oh, that would be nice", I will stop now with further S&R

I have tried to clean up a little bit the two header files, but that's more difficult than thought
m_cursor => cursorPosition() is also not so easy
There was no comment regarding m_startPos => startPos()
m_mouse => mousePosition(), not investigated
Who can I bother regarding stuff on kate-editor.org ?

I think is an improvement - sorry for the delay :( will integrate tomorrow.

This revision is now accepted and ready to land.Dec 7 2018, 9:36 PM

In D17382#372925, @dhaumann wrote:

sorry for the delay :(

What? No, it was pretty fast :-)
But I have a couple of Sonnet stuff where no progress happens :-/

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/view/kateview.cpp (10 lines)
M			src/view/kateviewaccessible.h (2 lines)
M			src/view/kateviewinternal.h (15 lines)
M			src/vimode/inputmodemanager.cpp (2 lines)