KateViewInternal: Rename getMouse/Cursor() => mouse/cursorPosition() to fit coding style
ClosedPublic

Authored by loh.tar on Thu, Dec 6, 3:02 PM.

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
loh.tar created this revision.Thu, Dec 6, 3:02 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptThu, Dec 6, 3:02 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
loh.tar requested review of this revision.Thu, Dec 6, 3:02 PM

Without any special "Oh, that would be nice", I will stop now with further S&R

  • I have tried to clean up a little bit the two header files, but that's more difficult than thought
  • m_cursor => cursorPosition() is also not so easy
  • There was no comment regarding m_startPos => startPos()
  • m_mouse => mousePosition(), not investigated
  • Who can I bother regarding stuff on kate-editor.org ?
dhaumann accepted this revision.Fri, Dec 7, 9:36 PM
dhaumann added a subscriber: dhaumann.

I think is an improvement - sorry for the delay :( will integrate tomorrow.

This revision is now accepted and ready to land.Fri, Dec 7, 9:36 PM

sorry for the delay :(

What? No, it was pretty fast :-)
But I have a couple of Sonnet stuff where no progress happens :-/

This revision was automatically updated to reflect the committed changes.