Differential D17351

make use of the new currentIndex api of QML kcms
ClosedPublic
Actions

Authored by mart on Dec 4 2018, 4:13 PM.

Details

Reviewers
jgrulich
Group Reviewers
Plasma
Commits
R295:313be515b2f8: make use of the new currentIndex api of QML kcms
Summary

sync kcm currentindex with the pagerow's
depends from D17350

Test Plan

tested with newtowrkmanager qml rewrite of the KCM

Diff Detail

Repository
R295 KCMUtils
Branch
phab/missingapi
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5691
Build 5709: arc lint + arc unit
mart created this revision.Dec 4 2018, 4:13 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 4 2018, 4:13 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mart requested review of this revision.Dec 4 2018, 4:13 PM
mart added a reviewer: jgrulich.Dec 4 2018, 4:15 PM
mart edited the summary of this revision. (Show Details)
jgrulich accepted this revision.Dec 5 2018, 6:37 AM

Looks good to me.

This revision is now accepted and ready to land.Dec 5 2018, 6:37 AM
Closed by commit R295:313be515b2f8: make use of the new currentIndex api of QML kcms (authored by mart). · Explain WhyDec 5 2018, 10:00 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kcmoduleqml.cpp (17 lines)
Msrc/kcmoduleqml_p.h (2 lines)

Diff 46847

View Options

src/kcmoduleqml.cpp

Loading...
View Options

src/kcmoduleqml_p.h

Loading...