Add the missing api for multilevel KCMs to control the columns
ClosedPublic

Authored by mart on Tue, Dec 4, 4:10 PM.

Details

Summary
  • add currentIndex and depth, which would map to the view in SystemSettings using a Kirigami PageRow (but not necessarly)
  • On multilevel kcms, Fix layout alignment issues that would prevent

ScrollViewKCM and SimpleKCM when displayed one besides the other to look
aligned with each other

Test Plan

tested most current QML kcms, tested the new features extensively
with the QML networkmanager kcm rewrite

Diff Detail

Repository
R296 KDeclarative
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Tue, Dec 4, 4:10 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptTue, Dec 4, 4:10 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mart requested review of this revision.Tue, Dec 4, 4:10 PM
ngraham added a subscriber: ngraham.Tue, Dec 4, 5:18 PM

That plasma-nm QML rewrite is looking totally awesome! How soon can we get it committed?

abetts added a subscriber: abetts.Tue, Dec 4, 5:49 PM

Instead of connection name, would it make sense to call it, network name instead?

That plasma-nm QML rewrite is looking totally awesome! How soon can we get it committed?

I unfortunately didn't have time to work on that since Akademy so there is no progress and lots of work ahead. I was thinking of working on that during Christmas break, to move it forward a bit, but my best guess would be to have it ready for Plasma 5.16, definitely not 5.15.

@mart , can you push your changes for plasma-nm so I can try this?

mart added a comment.Wed, Dec 5, 9:36 AM

@mart , can you push your changes for plasma-nm so I can try this?

sure!
can you ship it this too, so i get it all off in?

jgrulich accepted this revision.Wed, Dec 5, 9:41 AM
This revision is now accepted and ready to land.Wed, Dec 5, 9:41 AM
This revision was automatically updated to reflect the committed changes.
mart added a comment.Wed, Dec 5, 10:06 AM

All is in now :)
(connection name became Network name as requested)

Has the new QML KCM landed now? Or is it in some WIP branch somewhere?

Has the new QML KCM landed now? Or is it in some WIP branch somewhere?

It's in a branch in plasma-nm, the branch is called "plasma-kcm", but as I said, it has basically no functionality, you cannot configure any connection yet.