KRDC: add default shortcut to open new connection
ClosedPublic

Authored by knambiar on Dec 3 2018, 9:43 AM.

Details

Summary

Add the default (Ctrl+n) shortcut to open new connection in KRDC

Test Plan
  1. Compile & build new version
  2. Run krdc
  3. Press Ctrl+n
  4. Should open up new connection window

Diff Detail

Repository
R436 KRDC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
knambiar requested review of this revision.Dec 3 2018, 9:43 AM
knambiar created this revision.
knambiar added a reviewer: uwolfer.
$ arc patch D17327
 INFO  Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D17327.
Checking patch a/mainwindow.cpp => b/mainwindow.cpp...
error: a/mainwindow.cpp: does not exist in index

 Patch Failed! 
Usage Exception: Unable to apply patch!

The patch is strange, it contains diff --git a/a/mainwindow.cpp b/b/mainwindow.cpp
Can you setup and use arcanist to work with KDE Phabricator, or upload correct patch? ๐Ÿ˜‰ https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches

knambiar updated this revision to Diff 51241.Sat, Feb 9, 10:27 AM

Sorry about the wrong path in previous diff. Please find the updated one.

alexeymin accepted this revision.Sat, Feb 9, 2:45 PM

I tested, compiles and works, does not open any new windows for me, just focuses address input (I don't have any connections configured). Looks harmless overall, +1

This revision is now accepted and ready to land.Sat, Feb 9, 2:45 PM

I tested, compiles and works, does not open any new windows for me, just focuses address input (I don't have any connections configured). Looks harmless overall, +1

Which is the expected behaviour. KRDC opens new connections in `tabs', so pressing Ctrl+N actually opens a tab.
Here's how to test.

  1. Start krdc
  2. Press Ctrl+N (focus is on existing new connection address)
  3. Enter the server address and connect
  4. Press Ctrl+N again (for a new connection)
  5. A new tab will be open and focused at the address for next server
This revision now requires review to proceed.Sun, Feb 10, 6:07 AM
uwolfer accepted this revision.Sun, Feb 10, 10:21 AM

LGTM. Thanks.

This revision is now accepted and ready to land.Sun, Feb 10, 10:21 AM
This revision was automatically updated to reflect the committed changes.