Differential D17273

Extend unit tests to check comparisons of multi-digit numeric properties
ClosedPublic
Actions

Authored by bruns on Nov 30 2018, 11:19 PM.

Details

Reviewers
ngraham
poboiko
mgallien
Group Reviewers
Baloo
Frameworks
Commits
R293:8a390e188be2: Extend unit tests to check comparisons of multi-digit numeric properties
Summary

The unit test only checked for single digit values, and failed to check
for multi digit values. One prominent example is Rating=10, but this
also affected any other numeric comparison.

Test Plan

$ ctest
$ baloosearch 'linecount>=100'
$ baloosearch 'rating>9'

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Nov 30 2018, 11:19 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptNov 30 2018, 11:19 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Nov 30 2018, 11:19 PM
ngraham accepted this revision.Dec 1 2018, 4:16 AM
This revision is now accepted and ready to land.Dec 1 2018, 4:16 AM
Closed by commit R293:8a390e188be2: Extend unit tests to check comparisons of multi-digit numeric properties (authored by bruns). · Explain WhyDec 1 2018, 1:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 46618

View Options

autotests/unit/engine/postingdbtest.cpp

Loading...