Differential D17269

Fix build failure in neon by adding QVariant include.
AbandonedPublic
Actions

Authored by scarlettclark on Nov 30 2018, 5:27 PM.

Details

Reviewers
apol
mart
ngraham
Summary

Build failed with error: invalid use of incomplete type ‘class QVariant’
By adding #include <QVariant> it now builds.

Test Plan

Builds successfully on neon.

Diff Detail

Repository
R244 KCoreAddons
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5560
Build 5578: arc lint + arc unit
scarlettclark created this revision.Nov 30 2018, 5:27 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 30 2018, 5:27 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
scarlettclark requested review of this revision.Nov 30 2018, 5:27 PM
ngraham accepted this revision.Nov 30 2018, 5:28 PM
ngraham added reviewers: apol, mart.
ngraham added a subscriber: ngraham.

Fixes it for me.

This revision is now accepted and ready to land.Nov 30 2018, 5:29 PM
bruns added a subscriber: bruns.Nov 30 2018, 5:55 PM

This should reference the appropriate Qt or KF5 version which removed the implicit QVariant include.

apol accepted this revision.Nov 30 2018, 6:26 PM

Thanks!

bruns added a comment.Nov 30 2018, 6:47 PM

The right reference here is likely https://phabricator.kde.org/D17078

src/lib/kaboutdata.h
37–38

No longer needed

scarlettclark updated this revision to Diff 46584.Nov 30 2018, 7:14 PM

Remove class QVariant as per bruns review comment.

Revision Contents
Changeset List

PathPackages
Msrc/lib/kaboutdata.h (3 lines)

Diff 46584

View Options

src/lib/kaboutdata.h

Loading...