KJob's are quite QObject heavy, we lose a non-trivial amount of time in
signal matching strings. This ports some Q_PRIVATE_SLOTS in FileCopyJob
and the Job base.
Details
Details
- Reviewers
apol - Commits
- R241:77efdfdaa4f0: Port some core Q_PRIVATE_SLOTS to new connect syntax
Relevant unit tests
Copied some files
Diff Detail
Diff Detail
- Repository
- R241 KIO
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 5549 Build 5567: arc lint + arc unit
src/core/filecopyjob.cpp | ||
---|---|---|
225 ↗ | (On Diff #46565) | Why this change? |
259 ↗ | (On Diff #46565) | Add q context |
260 ↗ | (On Diff #46565) | All slotProcessedSize does is call q->setProcessedAmount so you can probably call this directly |
263 ↗ | (On Diff #46565) | Same as processedSize |
src/core/job.cpp | ||
88 ↗ | (On Diff #46565) | Capture only this |
src/core/filecopyjob.cpp | ||
---|---|---|
225 ↗ | (On Diff #46565) | m_copyJob is a superclass of DirectCopyJob which doesn't have the signal. so it's this or q->connect(qobject_cast<DirectCopyJob*>(m_copyJob), ....) |