Port some core Q_PRIVATE_SLOTS to new connect syntax
ClosedPublic
Actions

Authored by davidedmundson on Nov 30 2018, 2:54 PM.

Details

Reviewers

Commits

R241:77efdfdaa4f0: Port some core Q_PRIVATE_SLOTS to new connect syntax

Summary

KJob's are quite QObject heavy, we lose a non-trivial amount of time in
signal matching strings. This ports some Q_PRIVATE_SLOTS in FileCopyJob
and the Job base.

Test Plan

Relevant unit tests
Copied some files

Diff Detail

Repository

R241 KIO

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 5549
Build 5567: arc lint + arc unit

davidedmundson created this revision.Nov 30 2018, 2:54 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptNov 30 2018, 2:54 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

davidedmundson requested review of this revision.Nov 30 2018, 2:54 PM

Harbormaster completed remote builds in B5545: Diff 46565.Nov 30 2018, 2:54 PM

broulik added a subscriber: broulik.Nov 30 2018, 3:30 PM

broulik added inline comments.

src/core/filecopyjob.cpp
207–208	Why this change?
241	Add `q` context
242	All `slotProcessedSize` does is call `q->setProcessedAmount` so you can probably call this directly
244–254	Same as `processedSize`
src/core/job.cpp
88–91	Capture only `this`

davidedmundson added inline comments.Nov 30 2018, 3:32 PM

src/core/filecopyjob.cpp
207–208	m_copyJob is a superclass of DirectCopyJob which doesn't have the signal. so it's this or q->connect(qobject_cast<DirectCopyJob*>(m_copyJob), ....)

update

Harbormaster completed remote builds in B5549: Diff 46570.Nov 30 2018, 4:05 PM

LGTM

This revision is now accepted and ready to land.Nov 30 2018, 4:27 PM

Closed by commit R241:77efdfdaa4f0: Port some core Q_PRIVATE_SLOTS to new connect syntax (authored by davidedmundson). · Explain WhyDec 3 2018, 9:28 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/core/filecopyjob.h (9 lines)
M			src/core/filecopyjob.cpp (102 lines)
M			src/core/job.cpp (13 lines)
M			src/core/job_base.h (7 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	46565	5f55311		Nov 30 2018, 2:54 PM	★	★
Diff 2	46570	5f55311	update	Nov 30 2018, 4:05 PM	★	★
Diff 3	46774	16edef0	R241:77efdfdaa4f056b9decd00eeae3cb64ea31884e5	Dec 3 2018, 9:25 AM	★	★