Differential D17207

Use KPasswordLineEdit
ClosedPublic
Actions

Authored by broulik on Nov 28 2018, 8:30 AM.

Details

Reviewers
jriddell
davidedmundson
ngraham
Commits
R121:a13b84e326e1: Use KPasswordLineEdit
Test Plan
  • I now get the eye button to show the password I typed
  • Typing wrong password still leads to auth failure
  • Typing correct password works

Diff Detail

Repository
R121 Policykit (Polkit) KDE Agent
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Nov 28 2018, 8:30 AM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 28 2018, 8:30 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Nov 28 2018, 8:30 AM
ngraham accepted this revision.Nov 28 2018, 8:34 PM
ngraham added a subscriber: ngraham.

Works great and the code looks sane, thanks!

This revision is now accepted and ready to land.Nov 28 2018, 8:34 PM
Closed by commit R121:a13b84e326e1: Use KPasswordLineEdit (authored by broulik). · Explain WhyNov 29 2018, 8:14 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MAuthDialog.cpp (2 lines)
MAuthDialog.ui (13 lines)

Diff 46456

View Options

AuthDialog.cpp

Loading...
View Options

AuthDialog.ui

Loading...