Don't ask for confimation when reloading
Needs RevisionPublic

Authored by nicolasfella on Mon, Nov 26, 6:31 PM.

Details

Reviewers
ngraham
cullmann
Group Reviewers
Kate
Summary

When reloading the document it is unnecessary to show the document modified dialog that offers to reload
since that is what the user expects.

BUG: 401376

Test Plan

Modify document externally, relaod via F5 -> no confirmation dialog

Diff Detail

Repository
R39 KTextEditor
Branch
noreloadconfirm
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5398
Build 5416: arc lint + arc unit
nicolasfella created this revision.Mon, Nov 26, 6:31 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptMon, Nov 26, 6:31 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
nicolasfella requested review of this revision.Mon, Nov 26, 6:31 PM
nicolasfella edited the summary of this revision. (Show Details)Mon, Nov 26, 6:32 PM

I don't think the change is a bad idea, thought should not the

delete m_modOnHdHandler;

stay, to avoid we have the pending message visible?

cullmann requested changes to this revision.Tue, Nov 27, 5:49 PM
This revision now requires changes to proceed.Tue, Nov 27, 5:49 PM