Differential D17178

Don't ask for confimation when reloading
ClosedPublic
Actions

Authored by nicolasfella on Nov 26 2018, 6:31 PM.

Details

Reviewers
ngraham
cullmann
Group Reviewers
Kate
Commits
R39:82a1673746ea: Don't ask for confimation when reloading
Summary

When reloading the document it is unnecessary to show the document modified dialog that offers to reload
since that is what the user expects.

BUG: 401376

Test Plan

Modify document externally, relaod via F5 -> no confirmation dialog

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Nov 26 2018, 6:31 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptNov 26 2018, 6:31 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
nicolasfella requested review of this revision.Nov 26 2018, 6:31 PM
nicolasfella edited the summary of this revision. (Show Details)Nov 26 2018, 6:32 PM
cullmann added a subscriber: cullmann.Nov 27 2018, 5:49 PM

I don't think the change is a bad idea, thought should not the

delete m_modOnHdHandler;

stay, to avoid we have the pending message visible?

cullmann requested changes to this revision.Nov 27 2018, 5:49 PM
This revision now requires changes to proceed.Nov 27 2018, 5:49 PM
nicolasfella updated this revision to Diff 47740.Dec 18 2018, 1:28 AM
  • delete m_modOnHdHandler
cullmann accepted this revision.Dec 19 2018, 7:02 AM

Ok with this, thanks!

This revision is now accepted and ready to land.Dec 19 2018, 7:02 AM
Closed by commit R39:82a1673746ea: Don't ask for confimation when reloading (authored by nicolasfella). · Explain WhyDec 20 2018, 10:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/document/katedocument.cpp (23 lines)

Diff 47918

View Options

src/document/katedocument.cpp

Loading...