Differential D17090

Use append instead of operator+= when appending to an QVector<int>
ClosedPublic
Actions

Authored by bruns on Nov 22 2018, 1:42 AM.

Details

Reviewers
ngraham
poboiko
lbeltrame
Group Reviewers
Baloo
Frameworks
Commits
R293:4b406b107792: Use append instead of operator+= when appending to an QVector<int>
Summary

operator+= could easily be taken for an algebraic addition, whereas the
meaning of append is obvious.

Diff Detail

Repository
R293 Baloo
Branch
submit
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5240
Build 5258: arc lint + arc unit
bruns created this revision.Nov 22 2018, 1:42 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptNov 22 2018, 1:42 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Nov 22 2018, 1:42 AM
lbeltrame accepted this revision.Nov 22 2018, 6:38 AM
This revision is now accepted and ready to land.Nov 22 2018, 6:38 AM
Closed by commit R293:4b406b107792: Use append instead of operator+= when appending to an QVector<int> (authored by bruns). · Explain WhyNov 23 2018, 12:28 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/engine/document.cpp (6 lines)

Diff 45988

View Options

src/engine/document.cpp

Loading...