breeze-icons was failing the TestSuite.scalable test because firewall-applet didn't have icons in a directory marked as scalable by the index.theme files. status/22 is a scalable directory.
Details
- Reviewers
ngraham - Group Reviewers
VDG Breeze - Commits
- R266:7e27acf7e1a8: Move firewall-applet icons to status category
Diff Detail
- Repository
- R266 Breeze Icons
- Branch
- add-firewall-applet-48px (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 5094 Build 5112: arc lint + arc unit
The scalable test still fails; you need to add more symlinks:
FAIL! : ScalableTest::test_scalable(icons:Applications) The following icons are not available in a scalable directory: firewall-applet-error firewall-applet-shields_up firewall-applet-panic Loc: [/home/dev/repos/breeze-icons/autotests/scalabletest.cpp(262)] FAIL! : ScalableTest::test_scalable(icons-dark:Applications) The following icons are not available in a scalable directory: firewall-applet-error firewall-applet-shields_up firewall-applet-panic Loc: [/home/dev/repos/breeze-icons/autotests/scalabletest.cpp(262)]
@ngraham Realistically, users will never need the 48px versions of each icon. Can I just make more symlinks of firewall-config or should I make icons that actually represent the other icons?
I'm sorry but this makes no sense at all, why is firewall-applet-error now suddenly firewall-config?
And why do you say users will never need a 48px verison of it?
firewall-applet and firewall-config are closely accociated: https://github.com/firewalld/firewalld/tree/master/src
firewall-applet is just an applet for the system tray showing the state of firewalld with an option to open firewall-config, so it makes sense to re-use the firewall-config icon. firewall-applet doesn't show up in the application menu or application menu searches either. Even if it did, only firewall-applet.svg would be used. The other firewall-applet-* icons will only be seen in the system tray applet itself and never at 48px.
firewall-applet does have a .desktop file, but it is placed into /etc/xdg/autostart, not /usr/share/applications
Thanks, much better now.
@aacid all of this confused me too at first, but these icons are targeting a particular piece of software and use case where they make sense.
@sitter sent me an email saying that it would be better to put the firewall-applet icons into status/. He's probably right and it would mean I don't need to make a bunch of pointless symlinks.
These symlinks as they stand are not poinless, they are wrong.
Icon sets are not "targeting a particular piece of software", icon sets are system wide and any software can ask for a given icon, so firewall-applet-shields_up symlinking to firewall-config in size 48 when in size 32 are clearly different is wrong.
Anyone opposed to moving the firewall-applet icons into the status category? status/22 is a scalable directory. If no-one speaks by tomorrow, I'm going to land the patch.