Depend on KDE Frameworks 5.41
ClosedPublic

Authored by heikobecker on Nov 18 2018, 10:33 AM.

Details

Summary

Allows us to drop the copied FindGLIB2 cmake module. 5.41.0 was
released in December 2017 and thus will be over a year old when
kmix 19.04 is planned to be released.
Also remove the distinction between minimal ECM and KF5 versions,
they are relesed with the same version since quite some time.

Diff Detail

Repository
R345 KMix
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5065
Build 5083: arc lint + arc unit
heikobecker requested review of this revision.Nov 18 2018, 10:33 AM
heikobecker created this revision.
marten accepted this revision.Nov 18 2018, 12:48 PM

The same applies to the included FindPulseAudio module. Will you submit a separate review for that (if you are able to test with PA)?

This revision is now accepted and ready to land.Nov 18 2018, 12:48 PM

Removed FindPulseAudio.cmake as well

The same applies to the included FindPulseAudio module. Will you submit a separate review for that (if you are able to test with PA)?

Done. Tested with PA at build time.

anthonyfieroni added inline comments.
CMakeLists.txt
10–11

Min version should be increased as well to 5.6 or higher. So that maybe should be done in frameworks internally, because now it's not noticeable.

Additionally raised the Qt requirement

heikobecker marked an inline comment as done.Nov 20 2018, 6:57 PM
heikobecker added inline comments.
CMakeLists.txt
10–11

The requirement of 5.41.0 was 5.7.0 so I used that.

Elimination of FindPulseAudio and updated version checks fine by me.

This revision was automatically updated to reflect the committed changes.
heikobecker marked an inline comment as done.