| ngraham | |
| ndavis |
| VDG |
BUG: 399253
FIXED-IN: 5.53
Change the archive-* action icons to represent actual archives instead of a generic document. The archive symbols were taken from the folder-achive 16px and 22px icons.
Change the fallback color in the embedded stylesheet to Shade Black.
Before:
| size | archive-extract | archive-insert | archive-remove |
|---|---|---|---|
| 22px |  |  |  |
After:
| size | archive-extract | archive-insert | archive-remove |
|---|---|---|---|
| 16px |  |  |  |
| 22px and 24px |  |  |  |
| 32px |  |  |  |
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Beautiful, just what I had in mind! Amazing what a little zipper will do. @ndavis, does this look good to you too?
Sorry, jumped the gun a bit. The orientation of the zypper needs to be horizontally reversed on the 16 and 22 px icons, then it will be perfectly consistent
LOL, I've gotten too used to openSUSE to speak normal english now.
Anyway, here are the 16 and 22px mimetype icons for reference:
16px
22px
Do you think this is more consistent:
I shortened the zipper to make more room for the action emblems, so it'll never be 100% consistent, but I agree this is an improvement.
Also the correct margin for the 32px icons is now 2px, right?
Do you think this is more consistent:
I shortened the zipper to make more room for the action emblems, so it'll never be 100% consistent, but I agree this is an improvement.
Also the correct margin for the 32px icons is now 2px, right?
yes, this is good, and yes, we are using the 2px margin defined in the HIG for 32px monochrome icons now.
I've had a good look at your patch now and everything is ok. Unless @ngraham has anything else to say, I think it's time to land this.