Android: improve clang support
ClosedPublic
Actions

Authored by apol on Nov 16 2018, 6:19 PM.

Details

Reviewers

Group Reviewers

Build System
Android

Commits

R240:06061b0e3ce4: Android: improve clang support

Summary

Infer the toolchain we are using through cmake's detection of ranlib
instead of asking the user to fill it.
It's only used in androiddeployqt and cmake expects it to be version
"clang" for clang builds while androiddeployqt expects it to be "4.9".

Diff Detail

Repository

R240 Extra CMake Modules

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

apol created this revision.Nov 16 2018, 6:19 PM

Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptNov 16 2018, 6:19 PM

Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. · View Herald Transcript

apol requested review of this revision.Nov 16 2018, 6:19 PM

Harbormaster completed remote builds in B4998: Diff 45606.Nov 16 2018, 6:19 PM

Looks ok to me, less stuff to set manually is always good.

This revision is now accepted and ready to land.Nov 16 2018, 6:26 PM

Closed by commit R240:06061b0e3ce4: Android: improve clang support (authored by apol). · Explain WhyNov 19 2018, 3:16 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			toolchain/Android.cmake (8 lines)
M			toolchain/ECMAndroidDeployQt.cmake (6 lines)
M			toolchain/deployment-file.json.in (6 lines)
M			toolchain/specifydependencies.cmake (8 lines)