Diffusion Extra CMake Modules 06061b0e3ce4

Android: improve clang support
06061b0e3ce4
Actions

Authored by apol on Nov 16 2018, 6:17 PM.

Description

Android: improve clang support

Summary:
Infer the toolchain we are using through cmake's detection of ranlib
instead of asking the user to fill it.
It's only used in androiddeployqt and cmake expects it to be version
"clang" for clang builds while androiddeployqt expects it to be "4.9".

Reviewers: Build System, Android, vkrause

Reviewed By: Android, vkrause

Subscribers: kde-frameworks-devel, kde-buildsystem

Tags: Frameworks, Build System

Differential Revision: https://phabricator.kde.org/D16930

Details

Committed

apol	Nov 19 2018, 3:16 PM

Reviewer

Android

Differential Revision

D16930: Android: improve clang support

Parents

R240:96d169b87292: FindQHelpGenerator: try to find Qt5Help instead of Qt5Core

Branches

Unknown

Tags

Unknown

apol committed R240:06061b0e3ce4: Android: improve clang support (authored by apol).Nov 19 2018, 3:16 PM

@apol when I started the work on https://codereview.qt-project.org/#/c/244363/ someone mentioned that it will be great if it will be a cpack script which creates the .apk.
I see you already did the work, will you be interested to upstream it to QtBase? I also saw that you started the work on Android support in KDevelop, if you want to add run & debug
support (not only for QtApps, but for any C++ apps) please fell free to use the what I've done in QtCreator.

In R240:06061b0e3ce4342b5cbb1c0e6c8d285b524e30f0#3715930, @vatra wrote:

@apol when I started the work on https://codereview.qt-project.org/#/c/244363/ someone mentioned that it will be great if it will be a cpack script which creates the .apk.
I see you already did the work, will you be interested to upstream it to QtBase? I also saw that you started the work on Android support in KDevelop, if you want to add run & debug
support (not only for QtApps, but for any C++ apps) please fell free to use the what I've done in QtCreator.

Hi bogdan,
I'm not using cpack for it at the moment, you can see what we have in ECM, if you find anything useful tell me and I'll see to it.
https://phabricator.kde.org/source/extra-cmake-modules/browse/master/toolchain/

Regarding KDevelop, I'll look into what's available there, maybe there's something to be shared too.