[windowswitcher] Implement keyboard navigation
ClosedPublic

Authored by ngraham on Nov 15 2018, 12:32 AM.

Details

Summary

Implements keyboard navigation via the up and down arrow keys for the Breeze window switcher.

Support for this went in with D16693.

CCBUG: 370185

Test Plan

Alt-tab, use arrow keys, it works!

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Nov 15 2018, 12:32 AM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 15 2018, 12:32 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Nov 15 2018, 12:32 AM
ngraham edited the summary of this revision. (Show Details)Nov 15 2018, 2:45 AM
graesslin accepted this revision.Nov 15 2018, 6:23 AM
This revision is now accepted and ready to land.Nov 15 2018, 6:23 AM
This revision was automatically updated to reflect the committed changes.

In the previous patch @Zren said:

"Breeze (Look and Feel)

Works?! I guess the ListView handles the key input?"

and the comments in this patch are copy pasted from the kdeplasma-addons ones from back when we needed the hack.

Are you sure it's needed?
/If/ focus is wrong, then we're going to have a problem with the accessibility reader that needs fixing regardless.

szafar added a subscriber: szafar.Feb 18 2019, 6:36 AM

Is there a similar feature for the "Large Icons" switcher? Using Left/Right arrow keys there would make a lot of sense.

Yes, that one already works in Plasma 5.15. All of them should now work with keyboard navigation, in fact.