Fix contrast and other small visual issues of Kdots icon
ClosedPublic

Authored by trickyricky26 on Nov 12 2018, 4:25 PM.

Details

Summary

Fix contrast with Breeze light color scheme as well small issues with the lines connecting the dots in the icon.

Before:


The blue line at the bottom is above the blue dot when it should be below. The line at the top does not reach far enough under the dot, a small gap is visible.

After:


The contrast with a Breeze Light background color is much better. The blue lines are now all one path and are properly below the blue dots. They all reach under the blue dots. The right red dot has a shadow. All shadows are now above the connecting lines.

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
trickyricky26 created this revision.Nov 12 2018, 4:25 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 12 2018, 4:25 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
trickyricky26 requested review of this revision.Nov 12 2018, 4:25 PM
trickyricky26 edited the summary of this revision. (Show Details)Nov 12 2018, 4:27 PM
ndavis added a subscriber: ndavis.Nov 12 2018, 5:04 PM

As a bugfix, it looks good to me! However, the contrast of this icon against a panel using the Breeze Light colorscheme is probably bad. I'll ask the VDG if we should do another remake like we did with the sublime-text icon.

If the contrast is bad, I don't think this would require a full re-do; probably the light gray outline around the square could just be darkened up a bit.

If the contrast is bad, I don't think this would require a full re-do; probably the light gray outline around the square could just be darkened up a bit.

Yes, a gradient on the background square instead of just a solid color would be good too

I think a shadow should also be added to the center red dot. For some reason, it's the only dot without a shadow.


I have darkened the border, made the tiles a sublte gradient, and put a shadow on the red dot. I have also removed a line in the bottom left corner where there should just be a normal tile.

The contrast is now ok, even in the worst case scenerio with Breeze light and no shadow:

ndavis accepted this revision.Nov 12 2018, 5:50 PM

This is way better. Looks good to me! @ngraham ?

This revision is now accepted and ready to land.Nov 12 2018, 5:50 PM
ngraham accepted this revision.Nov 12 2018, 5:52 PM

Same. That's fantastic!

Let's also update the title so the commit message is accurate.

trickyricky26 updated this revision to Diff 45372.EditedNov 12 2018, 5:55 PM
  • Improved contrast with Breeze Light theme and a few minor visual changes

I also lifted the shadows of the dots above their connecting lines.

Final version:

trickyricky26 retitled this revision from Fix small visual issues of Kdots icon to Fix contrast and other small visual issues of Kdots icon.Nov 12 2018, 5:58 PM
trickyricky26 edited the summary of this revision. (Show Details)
trickyricky26 edited the summary of this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.