Differential D16822

Add 'Open Containing Folder' to Project plugin's tree context menu
ClosedPublic
Actions

Authored by gregormi on Nov 11 2018, 5:01 PM.

Details

Reviewers
cullmann
Group Reviewers
Kate
Commits
R40:d0a98dfd45fc: Add 'Open Containing Folder' to Project plugin's tree context menu
Summary

Plus:

  • Reorder Qt include statements alphabetically
  • Compact code which adds menu actions
  • Make action handling code a bit more resilient by using const
  • Cleanup: Remove KIO_VERSION check because it is no longer needed

Screenshot:

Diff Detail

Repository
R40 Kate
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gregormi created this revision.Nov 11 2018, 5:01 PM
Restricted Application added a project: Kate. · View Herald TranscriptNov 11 2018, 5:01 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
gregormi requested review of this revision.Nov 11 2018, 5:01 PM
gregormi edited the summary of this revision. (Show Details)Nov 11 2018, 5:04 PM
gregormi added a reviewer: Kate.
gregormi edited the summary of this revision. (Show Details)Nov 11 2018, 5:07 PM
broulik added a subscriber: broulik.Nov 11 2018, 7:02 PM

Check the CMakeLists.txt on root level, which says set(KF5_DEP_VERSION "5.40.0")

gregormi edited the summary of this revision. (Show Details)Nov 19 2018, 10:07 PM
gregormi updated this revision to Diff 45848.Nov 19 2018, 10:27 PM
  • Remove KIO ifdef
gregormi retitled this revision from WIP: Add 'Open Containing Folder' to Project plugin's tree context menu to Add 'Open Containing Folder' to Project plugin's tree context menu.Nov 19 2018, 10:29 PM
gregormi edited the summary of this revision. (Show Details)
cullmann accepted this revision.Nov 20 2018, 9:07 PM
cullmann added a subscriber: cullmann.

Nice, too. Thanks.

This revision is now accepted and ready to land.Nov 20 2018, 9:07 PM
Closed by commit R40:d0a98dfd45fc: Add 'Open Containing Folder' to Project plugin's tree context menu (authored by gregormi). · Explain WhyNov 20 2018, 10:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 45919

View Options

addons/project/kateprojecttreeviewcontextmenu.cpp

Loading...
View Options

kate/kateviewspace.cpp

Loading...