Differential D16794

Add output orientation size helper
ClosedPublic
Actions

Authored by romangg on Nov 9 2018, 10:53 PM.

Tags

Subscribers

Details

Reviewers

Group Reviewers

Commits

R108:6857fe54776b: Add output orientation size helper

Summary

In order to reduce code duplication add this helper
to AbstractOutput.

Diff Detail

Repository

Branch

orientatedSizeHelper

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 4789
Build 4807: arc lint + arc unit

romangg created this revision.Nov 9 2018, 10:53 PM

Restricted Application added a project: KWin. · View Herald TranscriptNov 9 2018, 10:53 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

romangg requested review of this revision.Nov 9 2018, 10:53 PM

Harbormaster completed remote builds in B4789: Diff 45214.Nov 9 2018, 10:53 PM

romangg added a dependency: D16793: Move output refresh rate getter into AbstractOutput.Nov 9 2018, 10:54 PM

davidedmundson accepted this revision.Nov 12 2018, 1:30 PM

This revision is now accepted and ready to land.Nov 12 2018, 1:30 PM

Closed by commit R108:6857fe54776b: Add output orientation size helper (authored by romangg). · Explain WhyNov 14 2018, 7:05 PM

This revision was automatically updated to reflect the committed changes.

orientateSize()?

Shouldn't that be orientSize() or orientationSize()?

Revision Contents
Changeset List

			Path	Packages
M			abstract_output.h (2 lines)
M			abstract_output.cpp (13 lines)
M			plugins/platforms/drm/drm_output.cpp (6 lines)

Diff 45214

abstract_output.h

Loading...

abstract_output.cpp

Loading...

plugins/platforms/drm/drm_output.cpp

Loading...