The search result highlight was using the whole container width,
this creates some glitches when scrolling because the right-most
part of the line is not repainted.
Limiting the search highlight to the number of columns fixes this
and is more consistent with line selection highlight too.
Details
Details
- Reviewers
hindenburg - Group Reviewers
Konsole - Commits
- R319:d76958bd396f: [Terminal display] Limit the search result line highlight width
Highlight a line by searching something in the konsole, then scroll.
There should be no glitches left on the right.
Diff Detail
Diff Detail
- Repository
- R319 Konsole
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Looks fine thanks - unrelated to this, but i notice when closing the search box, the old highlight lines are not removed when hitting ESC sometimes.
Comment Actions
Do you know how to reproduce that ? I could try to fix this, but I have not been able to reproduce it.
Comment Actions
Found it, proposed fix in https://phabricator.kde.org/D16754, but I think there is a problem with what I tried to do there ...