Properly close search when hitting Escape
ClosedPublic

Authored by thsurrel on Nov 8 2018, 11:05 AM.

Details

Summary

When performing a search and the focus is no longer on the
searchbox, hitting escape would hide the searchbox but would
not really end the search.

Test Plan

Search something in the terminal, then click within konsole
but outside the searchbox so that it loses focus and hit
escape. The search highlightings should now be removed.

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
thsurrel created this revision.Nov 8 2018, 11:05 AM
Restricted Application added a project: Konsole. · View Herald TranscriptNov 8 2018, 11:05 AM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
thsurrel requested review of this revision.Nov 8 2018, 11:05 AM

I don't know if I'm allowed to do that ... :-/

thsurrel updated this revision to Diff 45110.Nov 8 2018, 11:17 AM

That should be better...

ngraham added a subscriber: ngraham.Nov 8 2018, 3:32 PM

+1, works great for me.

hindenburg accepted this revision.Nov 10 2018, 1:37 AM
hindenburg added a subscriber: hindenburg.

Thanks

This revision is now accepted and ready to land.Nov 10 2018, 1:37 AM
This revision was automatically updated to reflect the committed changes.