Replacing connect() lines with the new signal/slot syntax in Qt5. Details: https://wiki.qt.io/New_Signal_Slot_Syntax.
There many of them. This is the third part.
abika |
Krusader |
Replacing connect() lines with the new signal/slot syntax in Qt5. Details: https://wiki.qt.io/New_Signal_Slot_Syntax.
There many of them. This is the third part.
No Linters Available |
No Unit Test Coverage |
Buildable 4863 | |
Build 4881: arc lint + arc unit |
krusader/KViewer/lister.cpp | ||
---|---|---|
1933–1934 | Maybe it would be better to declare KIO::TransferJob *saveJob = KIO::put(url, -1, KIO::Overwrite); and avoid dynamic casts? |
Please get rid of the dynamic casts. Everything else is fine. Thanks!
krusader/KViewer/lister.cpp | ||
---|---|---|
1933–1934 | yes, i agree. | |
krusader/Konfigurator/krresulttable.cpp | ||
200 | here, too: better change the type of _label to KUrlLabel | |
krusader/Panel/krlayoutfactory.cpp | ||
305 | And here, too: please change the type of frame to ListPanelFrame and panel to ListPanel. | |
krusader/Synchronizer/synchronizerdirlist.cpp | ||
146–148 | And here, too: please change the type of job to ListJob. |
Can I push it now to the master?
Thank you,
Miro
krusader/Konfigurator/krresulttable.cpp | ||
---|---|---|
200 | _label as QLabel is used for creating more compoments, many of them are Qlabels, so it won't work without bigger refactoring. So I won't change it | |
krusader/Panel/krlayoutfactory.cpp | ||
305 | Panel to ListPanel is not so strait forward. It forces dynamic cast at KrLayoutFactory constructor: KrLayoutFactory(QWidget *panel, QHash<QString, QWidget*> &widgets) : panel(panel), widgets(widgets) {} So I won't change it |