Differential D16685

Fix issue where there's only one element on the menu
ClosedPublic
Actions

Authored by apol on Nov 5 2018, 2:00 PM.

Details

Reviewers
mart
ngraham
Group Reviewers
Frameworks
Commits
R858:8fa114df0ad1: Fix issue where there's only one element on the menu
Summary

This (random) height shows an odd padding on the menu when there's just the one
element.

CCBUG: 400517

Test Plan

I don't get it anymore on Discover

Diff Detail

Repository
R858 Qt Quick Controls 2: Desktop Style
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4593
Build 4611: arc lint + arc unit
apol created this revision.Nov 5 2018, 2:00 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 5 2018, 2:00 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Nov 5 2018, 2:00 PM
ngraham accepted this revision.Nov 5 2018, 2:20 PM
ngraham added a subscriber: ngraham.

Seems like this is only a problem if you have a single-item menu, and if you have that, you've done something wrong. :) Regardless, this seems to fix the issue, so +1.

This revision is now accepted and ready to land.Nov 5 2018, 2:20 PM
mart accepted this revision.Nov 5 2018, 2:40 PM
Closed by commit R858:8fa114df0ad1: Fix issue where there's only one element on the menu (authored by apol). · Explain WhyNov 5 2018, 3:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Morg.kde.desktop/Menu.qml (1 line)

Diff 44908

View Options

org.kde.desktop/Menu.qml

Loading...