Differential D16676

[server] Put text-input (de-)activate, en-/disable callbacks in child classes
ClosedPublic
Actions

Authored by romangg on Nov 5 2018, 1:33 AM.

Details

Reviewers
davidedmundson
zzag
Group Reviewers
KWin
Frameworks
Commits
R127:12e46aa19296: [server] Put text-input (de-)activate, en-/disable callbacks in child classes
Summary

The activate/deactivate and enable/disable callback functionality was in the
TextInputInterface::Private interface, but these calls are each specific to v0
and v2 of the protocol.

Since v3 will have again a different function signature, put all the callbacks
and their helper functions in the protocol version specific child classes.

Test Plan

Compiles, runs.

Diff Detail

Repository
R127 KWayland
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
romangg created this revision.Nov 5 2018, 1:33 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 5 2018, 1:33 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
romangg requested review of this revision.Nov 5 2018, 1:33 AM
romangg retitled this revision from [server] Put (de-)activate, en-/disable callbacks in child classes to [server] Put text-input (de-)activate, en-/disable callbacks in child classes.Nov 5 2018, 4:24 PM
zzag added a subscriber: zzag.Nov 6 2018, 11:54 AM
zzag added inline comments.
src/server/textinput_interface_v0.cpp
92

This seems to be different.

romangg added inline comments.Nov 6 2018, 12:05 PM
src/server/textinput_interface_v0.cpp
92

Shouldn't make a difference, but it's an unneeded change, so I'll revert to surface again.

davidedmundson accepted this revision.Nov 6 2018, 12:24 PM
This revision is now accepted and ready to land.Nov 6 2018, 12:24 PM
zzag accepted this revision.Nov 6 2018, 12:25 PM
romangg marked 2 inline comments as done.Nov 6 2018, 12:52 PM
Closed by commit R127:12e46aa19296: [server] Put text-input (de-)activate, en-/disable callbacks in child classes (authored by romangg). · Explain WhyNov 6 2018, 12:55 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 3 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Diff 44963

View Options

src/server/textinput_interface_v0.cpp

Loading...