Changes made in line_highlight to make the text editor in kturtle visible in dark theme.
Bug 359084
FIXED-IN: [KDE Plasma: 5.12.6]
Details
- Reviewers
- None
Diff Detail
- Repository
- R337 KTurtle
- Lint
Lint Skipped - Unit
Unit Tests Skipped
KTurtle isn't released with Plasma, so that can't be the solution.
Sounds like it should be using KColorScheme to figure out these colors?
Also the commit message describes what it does too verbatim. Saying why you're doing it and how it fixes it is usually more useful.
I'm not sure I understand the current problem, hence asking for a screenshot. It sounds to me like you're changing a colour for another because the current value doesn't fit your configuration, so it makes sense to query the configuration rather than just using a random other colour like we used to.
Changes made in line_highlight to make the text editor in kturtle visible in dark theme.
It looks like we already found someone who is trying fix it, see https://phabricator.kde.org/D15518.
So, should I discard the changes or let it be open till the other review gets closed?