Details
- Reviewers
tcanabrava cfeck - Group Reviewers
KDE Edu
Diff Detail
- Repository
- R337 KTurtle
- Branch
- mvalentino
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 4573 Build 4591: arc lint + arc unit
| src/editor.h | ||
|---|---|---|
| 159 | Declare the variables when you are going to use them. | |
| 160 | don't use this->, this is not java. | |
| 166–175 | Why are you setting the values of errorColor wordColor in a if-branch that you will not use? | |
| 171–175 | create a lambda so you don't need to pass bgColor.saturation() / value() three times. | |
| src/editor.h | ||
|---|---|---|
| 159 | Don't leave old code around commented, if someone ever needs to know what the code was, that's what git history is for. | |
| src/editor.h | ||
|---|---|---|
| 41 | having a comment here is weird, because you haven't actualyl change the line but the comment seems like you have, so you probably want to remove this comment and if needed make sure it is in the commit log? | |
Just this small thing and it can go in.
| src/editor.h | ||
|---|---|---|
| 148 | const QColor& pass the variable via reference, as it will eliminate the copy created between calls. | |
| src/editor.h | ||
|---|---|---|
| 152 | You need to range-limit the saturation value, otherwise Qt just outputs a qWarning and returns an invalid color. http://code.qt.io/cgit/qt/qtbase.git/tree/src/gui/painting/qcolor.cpp#n1080 | |