Bug 359084 - Dark themes unsupported
Needs ReviewPublic

Authored by krishremya on Nov 3 2018, 6:54 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

Changes made in line_highlight to make the text editor in kturtle visible in dark theme.
Bug 359084
FIXED-IN: [KDE Plasma: 5.12.6]

Diff Detail

Repository
R337 KTurtle
Lint
Lint Skipped
Unit
Unit Tests Skipped
krishremya created this revision.Nov 3 2018, 6:54 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptNov 3 2018, 6:54 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
krishremya requested review of this revision.Nov 3 2018, 6:54 PM
apol added a subscriber: apol.Nov 4 2018, 1:27 AM

KTurtle isn't released with Plasma, so that can't be the solution.

Sounds like it should be using KColorScheme to figure out these colors?

Also the commit message describes what it does too verbatim. Saying why you're doing it and how it fixes it is usually more useful.

In D16649#353684, @apol wrote:

KTurtle isn't released with Plasma, so that can't be the solution.

Sounds like it should be using KColorScheme to figure out these colors?

Also the commit message describes what it does too verbatim. Saying why you're doing it and how it fixes it is usually more useful.

Thanks for the suggestions. I'm curious to know why it won't work using QColors?

apol added a comment.Nov 5 2018, 12:02 AM

I'm not sure I understand the current problem, hence asking for a screenshot. It sounds to me like you're changing a colour for another because the current value doesn't fit your configuration, so it makes sense to query the configuration rather than just using a random other colour like we used to.

krishremya updated this revision to Diff 44895.Nov 5 2018, 11:50 AM
krishremya edited the summary of this revision. (Show Details)

Changes made in line_highlight to make the text editor in kturtle visible in dark theme.

In D16649#354212, @apol wrote:

I'm not sure I understand the current problem, hence asking for a screenshot. It sounds to me like you're changing a colour for another because the current value doesn't fit your configuration, so it makes sense to query the configuration rather than just using a random other colour like we used to.

cfeck added a subscriber: cfeck.Nov 5 2018, 12:12 PM

It looks like we already found someone who is trying fix it, see https://phabricator.kde.org/D15518.

It looks like we already found someone who is trying fix it, see https://phabricator.kde.org/D15518.

So, should I discard the changes or let it be open till the other review gets closed?