Differential D16618

add explicit to constructors
ClosedPublic
Actions

Authored by astippich on Nov 2 2018, 8:26 PM.

Details

Reviewers
bruns
mgallien
Group Reviewers
Frameworks
Commits
R286:2b20e8720ae3: add explicit to constructors
Summary

add explicit to constructors as suggested by EBN

Diff Detail

Repository
R286 KFileMetaData
Branch
explicit
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4490
Build 4508: arc lint + arc unit
astippich created this revision.Nov 2 2018, 8:26 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptNov 2 2018, 8:26 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
astippich requested review of this revision.Nov 2 2018, 8:26 PM
mgallien added a subscriber: mgallien.Nov 2 2018, 9:05 PM
mgallien added inline comments.
src/simpleextractionresult.h
42 ↗(On Diff #44724)

Given this class is exported, is this binary compatible ?

astippich planned changes to this revision.Nov 2 2018, 9:18 PM
astippich added inline comments.
src/simpleextractionresult.h
42 ↗(On Diff #44724)

I've been not really thinking about it while I was looking at the EBN stuff and pushed too fast

astippich updated this revision to Diff 44731.Nov 2 2018, 9:29 PM
  • don't change exported classes
mgallien accepted this revision.Nov 2 2018, 10:46 PM
This revision is now accepted and ready to land.Nov 2 2018, 10:46 PM
Closed by commit R286:2b20e8720ae3: add explicit to constructors (authored by astippich). · Explain WhyNov 4 2018, 9:42 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/externalextractor.h (2 lines)
Msrc/writers/taglibwriter.h (2 lines)

Diff 44731

View Options

src/externalextractor.h

Loading...
View Options

src/writers/taglibwriter.h

Loading...