add explicit to constructors
ClosedPublic
Actions

Authored by astippich on Nov 2 2018, 8:26 PM.

Details

Reviewers

bruns
mgallien

Group Reviewers

Frameworks

Commits

R286:2b20e8720ae3: add explicit to constructors

Summary

add explicit to constructors as suggested by EBN

Repository

R286 KFileMetaData

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript

astippich requested review of this revision.Nov 2 2018, 8:26 PM

mgallien added inline comments.

src/simpleextractionresult.h
42 ↗	(On Diff #44724)	Given this class is exported, is this binary compatible ?

astippich planned changes to this revision.Nov 2 2018, 9:18 PM

astippich added inline comments.

src/simpleextractionresult.h
42 ↗	(On Diff #44724)	I've been not really thinking about it while I was looking at the EBN stuff and pushed too fast

This revision is now accepted and ready to land.Nov 2 2018, 10:46 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/externalextractor.h (2 lines)
M			src/writers/taglibwriter.h (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	44724	19f0237		Nov 2 2018, 8:26 PM	★	★
Diff 2	44731	19f0237	- don't change exported classes	Nov 2 2018, 9:29 PM	★	★
Diff 3	44822	2fb80c0	R286:2b20e8720ae32857d7e44613e0f0cf206ebe4616	Nov 4 2018, 9:42 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
8cbce6143740	1a15a4f6c0d2	bee08338b227	Alexander Stippich	don't change exported classes	Nov 2 2018, 9:28 PM
bee08338b227	8426bf0148a2	19f0237fdc98	Alexander Stippich	add explicit to constructors (Show More…)	Nov 2 2018, 9:24 PM