Qt's touch event API is rather difficult and complex to implement.
As none of KWin's internal windows supports multi-touch gestures yet,
this is going the easy route and just simulates a left mouse button
press. If in future need arises for touch gesture support on KWin's
internal windows, this can be added.
Details
- Reviewers
mart - Group Reviewers
Plasma - Commits
- R108:ff88f938524d: Support touch events on KWin internal windows
Tested on exopc with DebugConsole and auto test
Diff Detail
- Repository
- R108 KWin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Doesn't the virtual keyboard need multi touch input? The "swipe" keyboard is a MultiPointTouchArea. Also I could imagine stiff mouse clicks jeopardizing a smooth typing experience; I don't know how smart the Qt keyboard is in that area, though.
Anyway, looking ok for now.
As said: if we see need for this in future we can still add it. I just got overwhelmed with the QTouchEvent class and chose the fast route as current master has no widget which can handle more than a single press event.
I just looked at the Keyboard.qml file and it looks to me like not making use of multi touch. I'm not aware of swipe support in QtVirtualKeyboard and I didn't get handwriting to compile on Linux.
Also I could imagine stiff mouse clicks jeopardizing a smooth typing experience; I don't know how smart the Qt keyboard is in that area, though.
so far all my testing for the virtual keyboard was with left mouse button. It worked good enough for my feeling.
While would be nice to have actual multitouch, for now is better than nothing, so let's go with this and think about multitouch if there will be a strong use case in the future