Differential D16605

[handler] Improve text if a file is shared
ClosedPublic
Actions

Authored by nicolasfella on Nov 2 2018, 2:34 AM.

Details

Reviewers
apol
Group Reviewers
KDE Connect
Commits
R224:357751ac6889: [handler] Improve text if a file is shared
Summary

The handler allows to easily integrate file sharing into various file managers. Make it appear nicer by removing the scheme and using a different wording when sending
files

Test Plan

Diff Detail

Repository
R224 KDE Connect
Branch
handler
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4466
Build 4484: arc lint + arc unit
nicolasfella created this revision.Nov 2 2018, 2:34 AM
Restricted Application added a project: KDE Connect. · View Herald TranscriptNov 2 2018, 2:34 AM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
nicolasfella requested review of this revision.Nov 2 2018, 2:34 AM
nicolasfella edited the test plan for this revision. (Show Details)Nov 2 2018, 2:35 AM
apol accepted this revision.Nov 2 2018, 11:30 PM
apol added a subscriber: apol.
apol added inline comments.
urlhandler/kdeconnect-handler.cpp
100

How about we set here (Device to send %1, url)?

This revision is now accepted and ready to land.Nov 2 2018, 11:30 PM
nicolasfella added inline comments.Nov 2 2018, 11:40 PM
urlhandler/kdeconnect-handler.cpp
100

Will do in a separate patch

Closed by commit R224:357751ac6889: [handler] Improve text if a file is shared (authored by nicolasfella). · Explain WhyNov 2 2018, 11:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Murlhandler/kdeconnect-handler.cpp (5 lines)

Diff 44685

View Options

urlhandler/kdeconnect-handler.cpp

Loading...