Change package manager icons to emblems
ClosedPublic

Authored by ndavis on Thu, Nov 1, 12:30 PM.

Details

Summary

The old package-* icons were hard to read and straddled the line between being
symbols for actions and package properties. I have changed them to emblems and
change the style to match. The new style should be much easier to read. I have
Also dropped the package-supported icon since each distro may prefer to use
their own logo. Currently, only Ubuntu uses that icon and it uses its logo.

Test Plan

YaST Software Manager with Breeze Dark

Screenshot of Synaptic will come later

Image of all the icons (some are symlinks to existing emblems)

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ndavis created this revision.Thu, Nov 1, 12:30 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptThu, Nov 1, 12:30 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ndavis requested review of this revision.Thu, Nov 1, 12:30 PM
ndavis added a subscriber: VDG.Thu, Nov 1, 12:31 PM
ndavis edited the test plan for this revision. (Show Details)Thu, Nov 1, 12:33 PM
ndavis edited the test plan for this revision. (Show Details)Thu, Nov 1, 1:00 PM
ndavis edited the test plan for this revision. (Show Details)Fri, Nov 2, 1:16 AM
ngraham added a subscriber: ngraham.Fri, Nov 2, 2:24 AM

These are pretty darn good. They no longer have package-related iconography, but maybe that's okay and they never needed it in the first place. I can see how it would actually get in the way given how these icons are actually used.

These icons are also used by Apper, which is a distro-agnostic KDE app you can try out to see how they look there.

I'm inclined to give 'em a thumbs up, but let's see what other VDG folks think as well!

ndavis added a comment.EditedFri, Nov 2, 12:18 PM

These are pretty darn good. They no longer have package-related iconography, but maybe that's okay and they never needed it in the first place. I can see how it would actually get in the way given how these icons are actually used.

Exactly. Given the context, the only things they could be associated with are packages. Putting any package related iconography in there would be completely redundant.

These icons are also used by Apper, which is a distro-agnostic KDE app you can try out to see how they look there.

I'm inclined to give 'em a thumbs up, but let's see what other VDG folks think as well!

Thanks! Apper might be easier to test than Synaptic if it doesn't need to be run as root, so I'll check it out. I can't get Synaptic to change themes on the KDE Neon live image. Never mind, Apper doesn't use any of the package-* icons. Back to figuring out how to make Synaptic work, if it even matters. I doubt many Kubuntu, KDE Neon or Debian users are going to go through the effort required to make it used a different theme.

ngraham accepted this revision.Fri, Nov 2, 5:32 PM
This revision is now accepted and ready to land.Fri, Nov 2, 5:32 PM
ndavis updated this revision to Diff 44713.EditedFri, Nov 2, 6:14 PM

Changed installed.svg symlink to target package-installed-updated.svg

The original target was package-reinstall.svg

I've changed it because the new version of package-installed-updated makes more sense

valorie added a subscriber: valorie.Fri, Nov 2, 7:08 PM

Could not Muon be updated in this way as well? It now uses a package icon for all packages which seems a waste of space.

ndavis added a comment.Fri, Nov 2, 7:11 PM

Could not Muon be updated in this way as well? It now uses a package icon for all packages which seems a waste of space.

Perhaps, and that would be great, but that would have to be done as a change to Muon, not breeze-icons

ngraham requested changes to this revision.Fri, Nov 2, 10:30 PM

This fails the symlink test:

$  (arcpatch-D16588) make test
Running tests...
Test project /home/dev/repos/breeze-icons
    Start 1: appstreamtest
1/5 Test #1: appstreamtest ....................   Passed    0.56 sec
    Start 2: symlink
2/5 Test #2: symlink ..........................***Failed    0.23 sec
    Start 3: newline
3/5 Test #3: newline ..........................   Passed    0.11 sec
    Start 4: dupe
4/5 Test #4: dupe .............................***Failed    0.01 sec
    Start 5: scalable
5/5 Test #5: scalable .........................***Failed    0.03 sec
2/5 Testing: symlink
2/5 Test: symlink
Command: "/home/dev/repos/breeze-icons/bin/symlink"
Directory: /home/dev/repos/breeze-icons/autotests
"symlink" start time: Nov 02 16:29 MDT
Output:
----------------------------------------------------------
********* Start testing of SymlinkTest *********
Config: Using QtTest library 5.11.2, Qt 5.11.2 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 7.3.0)
PASS   : SymlinkTest::initTestCase()
FAIL!  : SymlinkTest::test_broken() 
  Found broken symlinks:
    /home/dev/repos/breeze-icons/icons-dark/actions/16/unrequired.svg => /home/dev/repos/breeze-icons/icons-dark/actions/16/package-install.svg

Please fix.

This revision now requires changes to proceed.Fri, Nov 2, 10:30 PM
ndavis updated this revision to Diff 44736.Fri, Nov 2, 10:57 PM

Removed broken symlink. It was already copied to the emblems/16 directory, but I forgot to remove the old copy.

ngraham accepted this revision.Sat, Nov 3, 1:56 AM

Much better, thanks!

This revision is now accepted and ready to land.Sat, Nov 3, 1:56 AM
This revision was automatically updated to reflect the committed changes.