Differential D16583

use qlatin1 for embedded image extractor
ClosedPublic
Actions

Authored by astippich on Nov 1 2018, 10:50 AM.

Details

Reviewers
mgallien
bruns
apol
Commits
R286:0a26d39b27cb: use qlatin1 for embedded image extractor
Summary

Use QLatin1String where applicable instead
of QStringLiteral.

Diff Detail

Repository
R286 KFileMetaData
Branch
embedded_image_latin1
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4483
Build 4501: arc lint + arc unit
astippich created this revision.Nov 1 2018, 10:50 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptNov 1 2018, 10:50 AM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
astippich requested review of this revision.Nov 1 2018, 10:50 AM
bruns added a comment.Nov 1 2018, 8:55 PM

Please use proper Capitalization in the Summary.

src/embeddedimagedata.cpp
175 ↗(On Diff #44619)

can you add a line break here and below? Also add parentheses, like for "audio/mpeg" above.

astippich updated this revision to Diff 44718.Nov 2 2018, 7:24 PM
  • coding style
astippich marked an inline comment as done.Nov 2 2018, 7:24 PM
astippich edited the summary of this revision. (Show Details)
apol accepted this revision.Nov 2 2018, 11:41 PM
This revision is now accepted and ready to land.Nov 2 2018, 11:41 PM
Closed by commit R286:0a26d39b27cb: use qlatin1 for embedded image extractor (authored by astippich). · Explain WhyNov 4 2018, 9:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/embeddedimagedata.cpp (20 lines)

Diff 44718

View Options

src/embeddedimagedata.cpp

Loading...