Differential D16524

[Extractor] Use QDataStream serialization in place of cooked one
ClosedPublic
Actions

Authored by bruns on Oct 30 2018, 2:24 AM.

Details

Reviewers
ngraham
poboiko
lbeltrame
Group Reviewers
Baloo
Frameworks
Commits
R293:a3943b1fd575: [Extractor] Use QDataStream serialization in place of cooked one
Summary

There is no need to reinvent serialization of Qt data types, just use
the one provided.

Depends on D16523

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Oct 30 2018, 2:24 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptOct 30 2018, 2:24 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Oct 30 2018, 2:24 AM
lbeltrame accepted this revision.Oct 30 2018, 6:08 AM
This revision is now accepted and ready to land.Oct 30 2018, 6:08 AM
Closed by commit R293:a3943b1fd575: [Extractor] Use QDataStream serialization in place of cooked one (authored by bruns). · Explain WhyNov 6 2018, 12:12 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 44943

View Options

src/file/extractor/app.cpp

Loading...
View Options

src/file/extractorprocess.cpp

Loading...