If the cross fade animation is cancelled, we are not gracefully
unreference the previous window pixmap.
This change addresses that issue by using RAII approach to
reference/unreference the previous window pixmap.
davidedmundson |
KWin |
If the cross fade animation is cancelled, we are not gracefully
unreference the previous window pixmap.
This change addresses that issue by using RAII approach to
reference/unreference the previous window pixmap.
Manually. The Maximize and the Morphing Popups effect still work.
Lint OK |
No Unit Test Coverage |
Buildable 4211 | |
Build 4229: arc lint + arc unit |
libkwineffects/kwinanimationeffect.cpp | ||
---|---|---|
350 | This line ends up missing. It doesn't look to make sense, but it was added explicitly: |
libkwineffects/kwinanimationeffect.cpp | ||
---|---|---|
350 | I saw that commit and review on reviewboard, but... when exactly those glitches happen? If I maximize a translucent Konsole window, I don't see glitches. We can add repaint in the destructor of the lock, but then we need to document why that repaint is needed. |
FWIW, I'm not adamant about keeping that repaint line, but if there's a change not mentioned in the git comment I'll at least ask about it just to make sure it's not an accident.