Diffusion KWin 93abb9a27318

Don't cache value of popupWindow property in EffectWindow

Authored by zzag on Nov 12 2018, 10:47 AM.

Description

Don't cache value of popupWindow property in EffectWindow

Summary:
With the plasma shell protocol, a ShellClient gets its role/window type
after it's created, so the cached value of the popupWindow property in
EffectWindow can be wrong.

In addition to that, the value of the popupWindow property still can be
wrong because plasma shell surfaces don't have xdg-popup role, so we need
to check NetWM-based window type in ShellClient::isPopupWindow.

Reviewers: KWin, davidedmundson

Reviewed By: KWin, davidedmundson

Subscribers: davidedmundson, kwin

Tags: KWin

Differential Revision: https://phabricator.kde.org/D16835

Details

Committed
zzagNov 12 2018, 10:47 AM
Reviewer
KWin
Differential Revision
D16835: Don't cache value of popupWindow property in EffectWindow
Parents
R108:5da8b4c78ae0: Explicitly link and disable kcrash on kwin_wayland
Branches
Unknown
Tags
Unknown