| sebas |
| Plasma |
The idea is to have KWin provide a virtual keyboard. To support this
KWin uses the QT_IM_MODULE qtvirtualkeyboard and makes sure that the
QPA plugin loads it.
KWin has a new class VirtualKeyboard which acts as the focus object and
the "proxy" for input methods. The QPA plugin ensures that this is the
focusObject, so that all input method related events are sent to this
class. From there it will be possible to delegate to other applications
through the Wayland interfaces.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| virtualkeyboard.cpp | ||
|---|---|---|
| 292 | No those are already part of the contentHints() and already mapped. | |
| main_wayland.cpp | ||
|---|---|---|
| 449 ↗ | (On Diff #3988) | Don't do this. Otherwise qtvirtualkeyboard will be the only usable input method for Qt. IMHO for wayland there should be a wayland specific im module that talk to input method via wl_text. And X11 app should use a different QT_IM_MODULE. FYI: https://fcitx-im.org/wiki/Input_method_related_environment_variables |
| main_wayland.cpp | ||
|---|---|---|
| 449 ↗ | (On Diff #3988) |
That's totally fine in this case. It only affects KWin and KWin doesn't have any text input fields.
QtWayland uses wl_text by default if QT_IM_MODULE is not specified. I think that's exactly what you want.
Look at the file name, it's main_wayland.cpp ;-) Doesn't affect X11 at all. |
| main_wayland.cpp | ||
|---|---|---|
| 449 ↗ | (On Diff #3988) | Specifically, I mean X11 app under Wayland. Since kwin_wayland will start the session I wonder if it will be inherit by the whole desktop session. |
| main_wayland.cpp | ||
|---|---|---|
| 449 ↗ | (On Diff #3988) | I don't understand the concern. The QT_IM_MODULE env variable set here in the code only affects KWin. It is not passed to any other process. Setting QT_IM_MODULE env variables will still overwrite everything - except in KWin where the variable is pointless. So nothing changes except by default KWin can now offer a virtual keyboard. |
| main_wayland.cpp | ||
|---|---|---|
| 449 ↗ | (On Diff #3988) | Ah, ok, I misunderstood that this will inherit by session since I thought kwin start the script exit-with-session. But then I still have one minor concern, for any window that actually inside kwin (e.g. right click on title bar -> window specific settings), the input method will be forced to qtvirtualkeyboard. Though I know input method is not commonly being used there, but I don't think that's expected behavior for input method user. |
| main_wayland.cpp | ||
|---|---|---|
| 449 ↗ | (On Diff #3988) | That dialog is a separate binary kwin_rules_dialog. Except for the virtual keyboard and wayland debug console I don't think there are any user-facing kwin-internal windows (that are real windows, not counting stuff like close buttons on present windows and so on) |
| main_wayland.cpp | ||
|---|---|---|
| 449 ↗ | (On Diff #3988) | It's as Kai-Uwe says: KWin has no own windows. Everything are external programs launched by KWin with a cleaned up environment. The only input field where KWin accepts input is the dialog for setting a shortcut for a window. As KGlobalAccel doesn't support input methods it's not a problem either. |
