Differential D16348

Properly look for the libphonenumber dependency
ClosedPublic
Actions

Authored by vkrause on Oct 21 2018, 9:41 AM.

Details

Reviewers
bshah
svuorela
Commits
R20:cd90f4a7866a: Properly look for the libphonenumber dependency

Diff Detail

Repository
R20 Plasma Phone Components
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4093
Build 4111: arc lint + arc unit
vkrause requested review of this revision.Oct 21 2018, 9:41 AM
vkrause created this revision.
svuorela requested changes to this revision.Oct 21 2018, 9:57 AM

Very much an improvement. But we need a license file.

cmake/FindPhoneNumber.cmake
11

"the bsd license" is unfortunately a bit too unspecific, so copying over the full license text and placing it next to it is what we in general have done.

32

Doing something with targets would be nice.

This revision now requires changes to proceed.Oct 21 2018, 9:57 AM
vkrause added a subscriber: dfaure.Oct 21 2018, 10:08 AM
vkrause added inline comments.
cmake/FindPhoneNumber.cmake
11

I am not finding any additional license terms at the source unfortunately. @dfaure This is your file from https://github.com/KDAB/FatCRM/blob/master/cmake/FindPhoneNumber.cmake, what license is meant there exactly?

dfaure added a comment.Oct 22 2018, 8:13 AM

This seems copy/pasted from most of the attic cmake modules in ECM, which also say "the BSD license", with a reference to ECM's COPYING-CMAKE-SCRIPTS. Good enough?

vkrause updated this revision to Diff 44298.Oct 27 2018, 10:16 AM

Bring the find script up to ECM standards.

bshah accepted this revision.Oct 27 2018, 11:11 AM

Looks good to me.

svuorela accepted this revision.Oct 28 2018, 10:53 AM
This revision is now accepted and ready to land.Oct 28 2018, 10:53 AM
Closed by commit R20:cd90f4a7866a: Properly look for the libphonenumber dependency (authored by vkrause). · Explain WhyOct 28 2018, 10:59 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)
AMcmake/FindPhoneNumber.cmake (33 lines)
Mdialer/src/CMakeLists.txt (5 lines)

Diff 44009

View Options

CMakeLists.txt

Loading...
View Options

cmake/FindPhoneNumber.cmake

Loading...
View Options

dialer/src/CMakeLists.txt

Loading...