When a dataengine failed to load it would ask PackageKit to install it but it's generally not how we want to distribute plasmoid infrastructure these days and didn't work.
Details
Details
- Reviewers
mart - Group Reviewers
Plasma - Commits
- R242:38098e96e3d8: Remove ComponentInstaller
The interface didn't exist here, and I couldn't find it in the docs, and it's ancient anyway. Even if it worked, it would still fail to load the engine, have you install it (assuming it even finds it), and then you have to restart plasma to load it.
Diff Detail
Diff Detail
- Repository
- R242 Plasma Framework (Library)
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
https://github.com/hughsie/PackageKit/blob/master/src/org.freedesktop.PackageKit.Transaction.xml
Method InstallPackages
This requires of course we already have a valid package name. For this we probably have to rely on appstream, but need to define an appropriate <componen> id first.
e.g.
<component type='addon' > <id>org.kde.plasma.dataengine.time</id> <extends>org.kde.plasma</extends> <name>Time Dataengine</name> </component>
Comment Actions
Method InstallPackages
Thanks for the insight. In any case, the way the code "works" right now is probably not what we want. It has been unused for years and is unlikely to come back in that form, so we can rm it. If we were to support something like this we need to modernize the architecture using AppStream and what not anyway.
Comment Actions
FWIW my +1 is to removing it. The Appstream assessment is all right but fixing something nobody uses sounds like a waste of time. :P