Differential D16293

[wayland] Set better placement for XDG Toplevels
ClosedPublic
Actions

Authored by davidedmundson on Oct 18 2018, 9:47 AM.

Tags

Subscribers

Details

Reviewers

Group Reviewers

Commits

R108:bdf348c603b8: [wayland] Set better placement for XDG Toplevels

Summary

XDG Popups will have a transient parent and positional information.
XDG Toplevels can have a transient parent without having positional
information.

Currently we set that we have a transient placement hint of 0,0 which
means the newly opened children go to the top left of the parent.

This new code paths treat child top levels as dialogs centering them to
the parent.

BUG: 393167

Test Plan

Dolphin help->about
Appeared where it does on X

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

davidedmundson created this revision.Oct 18 2018, 9:47 AM

Restricted Application added a project: KWin. · View Herald TranscriptOct 18 2018, 9:47 AM

Restricted Application added a subscriber: kwin. · View Herald Transcript

davidedmundson requested review of this revision.Oct 18 2018, 9:47 AM

Harbormaster completed remote builds in B4018: Diff 43852.Oct 18 2018, 9:47 AM

That bug number seems incorrect, did you mean Bug 393167?

update bug number

Harbormaster completed remote builds in B4019: Diff 43853.Oct 18 2018, 9:53 AM

abetts added a subscriber: abetts.Oct 18 2018, 2:07 PM

abetts removed a subscriber: abetts.

Hmm, it looks like the ShellClient part is already in master.

This revision is now accepted and ready to land.Oct 23 2018, 7:33 AM

Hmm, it looks like the ShellClient part is already in master.

Yeah, it was relevant for this and for the XdgPopup stuff so I had it in both patches to keep them independent.

Closed by commit R108:bdf348c603b8: [wayland] Set better placement for XDG Toplevels (authored by davidedmundson). · Explain WhyOct 23 2018, 11:40 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			placement.cpp (2 lines)

Diff 44104

placement.cpp

Loading...