[wayland] Set better placement for XDG Toplevels
ClosedPublic

Authored by davidedmundson on Oct 18 2018, 9:47 AM.

Details

Summary

XDG Popups will have a transient parent and positional information.
XDG Toplevels can have a transient parent without having positional
information.

Currently we set that we have a transient placement hint of 0,0 which
means the newly opened children go to the top left of the parent.

This new code paths treat child top levels as dialogs centering them to
the parent.

BUG: 393167

Test Plan

Dolphin help->about
Appeared where it does on X

Diff Detail

Repository
R108 KWin
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4018
Build 4036: arc lint + arc unit
davidedmundson created this revision.Oct 18 2018, 9:47 AM
Restricted Application added a project: KWin. · View Herald TranscriptOct 18 2018, 9:47 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Oct 18 2018, 9:47 AM

That bug number seems incorrect, did you mean Bug 393167?

davidedmundson edited the summary of this revision. (Show Details)
davidedmundson removed a subscriber: broulik.

update bug number

abetts added a subscriber: abetts.Oct 18 2018, 2:07 PM
abetts removed a subscriber: abetts.
zzag accepted this revision.Oct 23 2018, 7:33 AM
zzag added a subscriber: zzag.

Hmm, it looks like the ShellClient part is already in master.

This revision is now accepted and ready to land.Oct 23 2018, 7:33 AM

Hmm, it looks like the ShellClient part is already in master.

Yeah, it was relevant for this and for the XdgPopup stuff so I had it in both patches to keep them independent.

This revision was automatically updated to reflect the committed changes.