Differential D16183

KCrash: fix crash (ironic heh) when used in an app without QCoreApplication
ClosedPublic
Actions

Authored by dfaure on Oct 13 2018, 7:33 PM.

Details

Reviewers
heikobecker
aacid
sitter
Commits
R285:6dbd0edec10f: KCrash: fix crash (ironic heh) when used in an app without QCoreApplication
R285:064f7642adc8: KCrash: fix crash (ironic heh) when used in an app without QCoreApplication
Summary

For instance in kio_help. The right fix is to create a QCoreApplication
in all kioslaves, but this commit preserves compatibility between KF 5.50
and 5.51 after KIO's commit d428fc8e6447ede81f1e1911d0b66b39265672f3

Test Plan

Starting khelpcenter, no more core files from kio_help in my cores directory.

Diff Detail

Repository
R285 KCrash
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3846
Build 3864: arc lint + arc unit
dfaure created this revision.Oct 13 2018, 7:33 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 13 2018, 7:33 PM
Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. · View Herald Transcript
dfaure requested review of this revision.Oct 13 2018, 7:33 PM
dfaure updated this revision to Diff 43555.Oct 13 2018, 7:34 PM

add bug number

heikobecker accepted this revision.Oct 13 2018, 8:32 PM

I can confirm that the crash doesn't occur anymore.

This revision is now accepted and ready to land.Oct 13 2018, 8:32 PM
dfaure closed this revision.Oct 14 2018, 9:27 AM
sitter added a comment.Oct 14 2018, 9:27 AM

KF5 style is to always {} single line if-else, no?

dfaure added a comment.Oct 14 2018, 9:33 AM

You're right. Fixed, thanks.

Revision Contents
Changeset List

PathPackages
Msrc/kcrash.cpp (5 lines)

Diff 43555

View Options

src/kcrash.cpp

Loading...