Fix the intial panel width when using xmonad (and probably other tiling WMs).
AbandonedPublic

Authored by tcberner on May 16 2016, 8:02 AM.

Details

Summary

The function PanelView::setLenght does not respect the values of m_minLength
and m_maxLength. This lead to a panel that is too short when using xmonad.
I.e. even though the panel with is set to maximise, it only is as short as
it is needed by the widgets on it.

This patch fixes this behaviour by making sure the intial value set to length
on startup is sensible given by the settings.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
tcberner updated this revision to Diff 3824.May 16 2016, 8:02 AM
tcberner retitled this revision from to Fix the intial panel width when using xmonad (and probably other tiling WMs). .
tcberner updated this object.
tcberner edited the test plan for this revision. (Show Details)
tcberner added a reviewer: drosca.
tcberner set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma. · View Herald TranscriptMay 16 2016, 8:02 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested changes to this revision.May 16 2016, 9:01 AM
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a subscriber: davidedmundson.

No.

Length refers to the size of the contents of the panel.

It should not be constrained by the user settings.

Changing the window size should be.

This revision now requires changes to proceed.May 16 2016, 9:01 AM

As an alternate fix look at ::resizePanel and make sure the args to resize() is constrained within min and max size.

mart added a subscriber: mart.May 16 2016, 9:09 AM

well, setLength, is pretty much a shortcut for setting the proper size (width or height) given the location..
i think the patch kinda makes sense

mart added a comment.May 16 2016, 9:17 AM

As an alternate fix look at ::resizePanel and make sure the args to resize() is constrained within min and max size.

Agree, that's the way to go

tcberner abandoned this revision.May 16 2016, 4:52 PM

This issue seems to be fixed with the resizePanel() you mentioned that has appeared in 12f7cbf5.