refactor tests for taglibextractor
ClosedPublic
Actions

Authored by astippich on Oct 11 2018, 5:23 PM.

Details

Reviewers

mgallien
bruns
svuorela

Commits

R286:2d6b448b69b0: refactor tests for taglibextractor

Summary

refactors all tests so that they can be reused for
files of different mimetype, but with the same metadata format

Diff Detail

Repository

R286 KFileMetaData

Branch

refactor_tests

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 3807
Build 3825: arc lint + arc unit

astippich created this revision.Oct 11 2018, 5:23 PM

Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptOct 11 2018, 5:23 PM

Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript

astippich requested review of this revision.Oct 11 2018, 5:23 PM

Harbormaster completed remote builds in B3768: Diff 43409.Oct 11 2018, 5:23 PM

Can you split this up in two patches, the first one updating the test files and fixing the values in the tests, and the second one doing the refactoring?

In D16135#341549, @bruns wrote:

Can you split this up in two patches, the first one updating the test files and fixing the values in the tests, and the second one doing the refactoring?

see D16162. I will rebase afterwards

rebase

Harbormaster completed remote builds in B3807: Diff 43490.Oct 12 2018, 6:27 PM

Looks good, thanks.

This revision is now accepted and ready to land.Oct 12 2018, 8:36 PM

Closed by commit R286:2d6b448b69b0: refactor tests for taglibextractor (authored by astippich). · Explain WhyOct 13 2018, 8:48 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M	(bin)	autotests/samplefiles/test.flac
M	(bin)	autotests/samplefiles/test.ogg
M	(bin)	autotests/samplefiles/test.opus
M		autotests/taglibextractortest.h (16 lines)
M		autotests/taglibextractortest.cpp (237 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	43409	d7c6fa5		Oct 11 2018, 5:23 PM	★	★
Diff 2	43490	1aab09a	- rebase	Oct 12 2018, 6:26 PM	★	★
Diff 3	43525	5836ca4	R286:2d6b448b69b0c685b28d1fa63639cd4d3b8b3779	Oct 13 2018, 8:48 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
85c61347dc25	7a26ba9aa44b	df58244ca9a8	Alexander Stippich	fix new line	Oct 12 2018, 6:25 PM
df58244ca9a8	c17887e011bf	551c4cd19752	Alexander Stippich	refactor tests for taglibextractor (Show More…)	Oct 11 2018, 5:20 PM
551c4cd19752	e444ca2594bf	1aab09a628ae	Alexander Stippich	convert vorbis comments to data driven test	Oct 11 2018, 5:13 PM