use own extractor for testing the taglibwriter
ClosedPublic

Authored by astippich on Oct 10 2018, 5:36 PM.

Details

Summary

Instead of querying the tags directly through taglib,
use the taglibextractor to read the written tags for the tests.
This will become useful once additional tags are added to the
taglibwriter that require manual querying and reading.
As a bonus, the now unneeded custom TString to QString function
is removed.

Test Plan

compiles and tests pass

Diff Detail

Repository
R286 KFileMetaData
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich created this revision.Oct 10 2018, 5:36 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptOct 10 2018, 5:36 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
astippich requested review of this revision.Oct 10 2018, 5:36 PM
bruns added inline comments.Oct 10 2018, 6:45 PM
autotests/taglibwritertest.cpp
5–7

double slash

56

IIRC TrackNumber and ReleaseYear are unsigned int, so this should be value(prop).toInt(), right?

bruns requested changes to this revision.Oct 10 2018, 6:45 PM
This revision now requires changes to proceed.Oct 10 2018, 6:45 PM
astippich updated this revision to Diff 43339.Oct 10 2018, 6:53 PM
  • fix stupid mistakes
astippich marked 2 inline comments as done.Oct 10 2018, 6:53 PM

Sorry, that was really stupid

bruns accepted this revision.Oct 10 2018, 7:05 PM
This revision is now accepted and ready to land.Oct 10 2018, 7:05 PM
This revision was automatically updated to reflect the committed changes.