Differential D16060

Reduce double and triple lookups to the frames hash
ClosedPublic
Actions

Authored by apol on Oct 9 2018, 8:03 AM.

Details

Reviewers
davidedmundson
broulik
Group Reviewers
Plasma
Commits
R242:d9b907e953a4: Reduce double and triple lookups to the frames hash
Test Plan

Everything runs, tests pass

Diff Detail

Repository
R242 Plasma Framework (Library)
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3674
Build 3692: arc lint + arc unit
apol created this revision.Oct 9 2018, 8:03 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 9 2018, 8:03 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
apol requested review of this revision.Oct 9 2018, 8:03 AM
davidedmundson accepted this revision.Oct 10 2018, 2:42 PM
This revision is now accepted and ready to land.Oct 10 2018, 2:42 PM
broulik added a subscriber: broulik.Oct 10 2018, 2:44 PM
broulik added inline comments.
src/plasma/framesvg.cpp
967

Can we assume references always contains svg?

davidedmundson added inline comments.Oct 10 2018, 2:47 PM
src/plasma/framesvg.cpp
967

if we're calling deref without it being paired with ref then we have bigger problems.

broulik accepted this revision.Oct 10 2018, 2:48 PM
broulik added inline comments.
src/plasma/framesvg.cpp
967

:D fair enough

Closed by commit R242:d9b907e953a4: Reduce double and triple lookups to the frames hash (authored by apol). · Explain WhyOct 11 2018, 3:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/plasma/framesvg.cpp (10 lines)

Diff 43192

View Options

src/plasma/framesvg.cpp

Loading...