Reduce double and triple lookups to the frames hash
ClosedPublic
Actions

Authored by apol on Oct 9 2018, 8:03 AM.

Details

Reviewers

davidedmundson
broulik

Group Reviewers

Plasma

Commits

Test Plan

Everything runs, tests pass

Repository

R242 Plasma Framework (Library)

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

apol requested review of this revision.Oct 9 2018, 8:03 AM

This revision is now accepted and ready to land.Oct 10 2018, 2:42 PM

broulik added inline comments.

src/plasma/framesvg.cpp
967–970	Can we assume `references` always contains `svg`?

src/plasma/framesvg.cpp
967–970	if we're calling deref without it being paired with ref then we have bigger problems.

broulik added inline comments.

src/plasma/framesvg.cpp
967–970	:D fair enough

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/plasma/framesvg.cpp (10 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	43192	0698c65		Oct 9 2018, 8:03 AM	★	★
Diff 2	43401	4b7bac2	R242:d9b907e953a475aae9c4eb0a10d7598516ec7b54	Oct 11 2018, 3:27 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
4349d27fe1bc	040a1557f76c	0698c65a831b	Aleix Pol	Reduce double and triple lookups to the frames hash (Show More…)	Oct 9 2018, 8:00 AM